Update warnings to be more helpful to users after 2026 Naomi estimates#485
Open
rtesra wants to merge 2 commits into
Open
Update warnings to be more helpful to users after 2026 Naomi estimates#485rtesra wants to merge 2 commits into
rtesra wants to merge 2 commits into
Conversation
r-ash
approved these changes
Jun 30, 2026
r-ash
left a comment
Contributor
There was a problem hiding this comment.
This looks good, I'm happy to merge this after we fix the build errors. I'll look into those errors, something failing when building the qs package which is a bit frustrating.
We should definitely check these messages display ok in the app once it is deployed. I think it should be fine, but we should check as they use lots of special characters for formatting the display.
| ) | ||
| expect_error( | ||
| artnum_mf("CY2017Q4", art_with_dups, a_naomi_mf), | ||
| "MWI_4_1_demo (Chitipa) | Y000_014 | sex=both | CY2017Q4 | n=2 records" |
Contributor
There was a problem hiding this comment.
Nice, I like the |, I think they are a bit clearer than what we've tried before when raising errors about rows of data.
r-ash
force-pushed
the
improve-warning-2026-debugs
branch
from
July 1, 2026 13:13
28eac41 to
98a1316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model
area_leveloption. Previously this caused a non-informativestopifnot(!is.na(mf_model[["population_t1"]]))failure; now the errornames both the model level and the population data level. (ETH, Debug 43)
artnum_mf(). Previously the errornamed model-level aggregated areas (which could mislead users to check the
wrong rows); now it reports the exact input
area_id, area name, age group,sex, quarter, and duplicate count for each offending row. (ETH, Debug 44)
select_naomi_data()to detect when ANC already-on-ARTcounts exceed total ANC positives. Previously this produced implausible ART
coverage values or a non-informative downstream error; now it stops early
with the affected area, area name, and year. (RWA, Debug 28)