feat: added bgg api key support#167
Merged
Merged
Conversation
github-actions
Bot
added
backend
frontend
tests
dependencies
.NET Test Results1 305 tests 1 305 ✅ 15s ⏱️ Results for commit 560436b. ♻️ This comment has been updated with latest results. |
🔍 Vulnerabilities of
|
| digest | sha256:84efce25c7837af92de9fc6e1fd70ba3cf0ef98edfc333acb22dfe315f1de12d |
| vulnerabilities |     |
| platform | linux/amd64 |
| size | 68 MB |
| packages | 113 |
📦 Base Image alpine:3
| also known as |
|
| digest | sha256:4d889c14e7d5a73929ab00be2ef8ff22437e7cbc545931e52554a7b00e123d8b |
| vulnerabilities |  |
Migrate both Node projects (boardgametracker.client and docs) from npm to pnpm 10, and resolve the 7 Dependabot-flagged vulnerabilities. Package manager: - Add packageManager field (pnpm@10.11.0) to both package.json files - Replace package-lock.json with pnpm-lock.yaml in both projects - Dockerfile frontend-build stage: corepack enable + pnpm install - All workflows: add pnpm/action-setup, switch cache to pnpm, replace npm ci/run/version/audit with pnpm equivalents - csproj SpaProxyLaunchCommand: npm run dev -> pnpm dev - Update npm references in docs snippets and authentication-guide.md Vulnerability fixes: - Bump axios -> ^1.15.2 (HIGH: prototype pollution) - Bump i18next-http-backend -> ^3.0.5 (path traversal) in both projects - Fresh lockfiles resolve transitive brace-expansion, ws, postcss - pnpm audit reports 0 vulnerabilities in both projects Also declares @radix-ui/react-popover as an explicit dependency in the client — it was a phantom dependency relied on via npm's flat node_modules and surfaced by pnpm's strict resolution. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The project had ~145 type errors that tsc reported but never blocked CI (the build script runs vite build without typechecking). Fixed all of them and added a typecheck gate so they cannot regress. Test files: - createMockField helpers now return AnyFieldApi via an explicit cast (shared helper in test-utils + 7 local form-test helpers) - Test data factories now include all required fields (Badge.type/level, PlayerSession.won/isBot, Player.badges, Location.playCount, MenuItem.mobileVisible) - BgtImageSelector test mocks typed as Dispatch/createObjectURL - RecentActivityCard TestItem.id widened to string | number - Updated stale BgtDatePicker tests (component was rewritten to a typeable input) and EditLocationModal assertion (payload now includes playCount) Source files: - tsconfig: target/lib ES2020 -> ES2022 (Object.hasOwn) - zodValidator: z.AnyZodObject -> z.ZodObject (removed in zod v4) - i18n: move custom formatter from interpolation.format to the formatter API (not in InterpolationOptions types) - useBadgeEarnedStatus: sort string enums via localeCompare / order array instead of broken numeric subtraction - ErrorFallback: narrow unknown error before accessing message/stack - UpdateGameNightRsvp: add missing id field (both call sites pass it) - Remove dead BgtCenteredCard imports (module no longer exists) - Export MostPlayedGame from models index - Various targeted fixes (OidcProvider.name, BgtPoster CSS vars, useMultiQuery result typing, settings form bggApiKey nullability, SessionFormApi store.subscribe return type, etc.) CI: - Add typecheck script (tsc --noEmit) and a "Typecheck frontend" step to ci.yml so type errors fail PRs going forward tsc --noEmit: 0 errors. 839 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.