Skip to content

Update download_paths.json to be compatible with newer versions of Playwright#36

Draft
MatrixFrog wants to merge 1 commit into
mrmeku:mainfrom
MatrixFrog:download-paths
Draft

Update download_paths.json to be compatible with newer versions of Playwright#36
MatrixFrog wants to merge 1 commit into
mrmeku:mainfrom
MatrixFrog:download-paths

Conversation

@MatrixFrog
Copy link
Copy Markdown

@MatrixFrog MatrixFrog commented Feb 11, 2026

(Currently still in progress but feel free to take a look to get the gist of it)

Several of these paths changed in Playwright in microsoft/playwright#38573 so rules_playwright without this change won't work with newer versions of Playwright, specifically 1.58.0 and up I believe.

On the other hand, with this change, it won't work with older versions of Playwright below 1.58.0, and could also be incompatible with future versions if Playwright changes their download paths again. So this is maybe not the ideal long-term fix but I don't know if Playwright provides a dependable public API for this information.

@kwesolowski-at-volvocars
Copy link
Copy Markdown

I tried this PR as a git_override pointing to this branch and it works well. Tested with (all fresh, no cache):

  • playwright==1.57.0 (Chrome 143.0.7499.4)
  • playwright==1.58.0 (the originally broken version)
  • playwright==1.59.0 (latest)

On the backward compatibility concern: I verified that the CfT CDN (storage.googleapis.com/chrome-for-testing-public) does host binaries for these versions. That said, it doesn't cover everything — the CfT CDN appears to start around Chrome 120 / Playwright 1.40 (late 2023); older versions like Playwright 1.39 (Chrome 119) return 404 on CfT. So anyone still on a pre-1.40 Playwright would be broken by this change, though that seems like a very small audience at this point.

Would be great to get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants