リフの試験が不安定なのを直す - #2
Merged
Merged
Conversation
jev スライダーは 1 へ滑らかに寄る途中なので、最初のリフは手元で選ばれることがあり、 Jev の答えを待たずに検証して落ちていた (手元で20回中3回)。 Co-authored-by: Claude Code <claude@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eh8BhqRx1yK8ANC5BXmJbb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1 のマージ後、main の CI で
tests/jev.spec.jsの「リフは Jev が選んだ候補の旋律で鳴る」が flaky になった (再試行で通過)。原因
試験は
jevスライダーを 1 にしてから再生する。けれど、判断に使う割合は 0.8 から 1 へ滑らかに寄っていく途中なので、最初のリフは約2割の確率で手元で選ばれる。その回は Jev に問い合わせない。試験は「リフが1回鳴るまで」しか待っていなかった。そのため、Jev の答えがまだ無いまま検証に進んで落ちていた。
修正
「Jev が選んだ旋律が鳴るまで」待つようにした。試験だけの変更で、本体は変えていない。
確かめたこと
🤖 Generated with Claude Code
https://claude.ai/code/session_01Eh8BhqRx1yK8ANC5BXmJbb