Repository navigation
chore(github): add a Discussions contact link to the issue templates - #103
Merged
Merged
Conversation
Ideas and workflow pain points now have a channel that is not the issue tracker, but nothing pointed to it. The issue chooser offered only "Bug Report", "Feature Request" and a blank issue, so the feedback that #11 collects would still have arrived as issues after Discussions was enabled. The Ideas category is now linked from the chooser, with the same wording the discussion itself uses, and it states what happens to an idea afterwards — it moves into its own issue with an owner, acceptance criteria and a milestone. That promise is the reason to route ideas here rather than through #11: an idea posted as a discussion can be converted into tracked work without the author restating it, which is not true of a comment buried in a long thread. `blank_issues_enabled` stays true, and the comment is rewritten because its original rationale — "plenty of feedback does not fit cleanly into bug or feature" — is now partly answered by Discussions, while a blank issue remains the right shape for a wrong claim in the README or a packaging surprise. No change to which templates are offered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Points the issue chooser at the Discussions Ideas category for feature requests and workflow pain points, so that feedback which is neither a bug report nor a fully-specified feature request has a home other than the issue tracker.
Why?
#11 was doing that job as an ordinary issue — a standing feedback thread with 10 comments of real user input, which is exactly the shape a Discussion is for. Discussions is now enabled, and #11 has been converted into #102 (all 10 comments carried over). But nothing in the issue chooser advertised the channel: a user opening "New issue" still sees only Bug Report, Feature Request and a blank issue.
The link also states the follow-through, because that is what makes Discussions trustworthy as an intake channel: approved ideas move into their own issue, with an owner, acceptance criteria and a milestone.
Linking the category rather than discussion #102 keeps this working as more threads are opened in Ideas.
Related issue
Related to #11 (now discussion #102)
What changed?
.github/ISSUE_TEMPLATE/config.yml— added onecontact_linksentry pointing athttps://github.com/mrsibe/KnowNote/discussions/categories/ideasblank_issues_enabledcomment, which justified itself with a rationale that Discussions now partly answersblank_issues_enableditself is unchanged (true), so which templates are offered does not changeHow was this tested?
blank_issues_enabled: trueplus a singlecontact_linksentry carrying exactly thename/url/aboutkeys GitHub requiresnpx prettier --check .github/ISSUE_TEMPLATE/config.yml— "All matched files use Prettier code style!"…/discussionsand…/discussions/categories/ideasreturn HTTP 200, and the Ideas category now contains discussion Feature requests & workflow pain points #102Known limitation: GitHub renders this file when the chooser page is requested, and it reads it from the default branch — so the rendered chooser cannot be verified from this branch. Worth a glance at https://github.com/mrsibe/KnowNote/issues/new/choose after merge.
Screenshots / recordings
N/A — no application UI change.
Checklist
npm run typecheckpasses. — not run: no TypeScript is touched. This PR changes one YAML config file under.github/npm run buildpasses. — not run, same reasonDesktop / build changes