Repository navigation
chore: declare the Node 24 LTS baseline in the repository - #183
Merged
Merged
Conversation
CI already runs Node 24 (`.github/workflows/verify.yml`, `release.yml`) and CONTRIBUTING already tells contributors to use Node 24, but nothing in the repository enforces or advertises it, so a contributor on Node 26 Current or Node 22 has no signal. - `engines.node: ">=24 <25"` so npm warns on a mismatch - `.node-version` = `24` for nodenv / asdf / fnm / mise - CONTRIBUTING points at both, and says not to develop against Current Node 24 is the Active LTS line and is also what Electron 44 embeds, so the development runtime and the packaged runtime agree. Not included on purpose: bumping the root `@types/node` from 22 to 24. That belongs with the Electron 39 -> 44 upgrade (which moves the main process from Node 22 to Node 24); doing it here would let main-process code typecheck against Node 24 APIs while Electron 39 still runs Node 22. Verified: `npm run typecheck` clean, `npm test` 469/469 pass, `npm run build` OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the already-true Node 24 requirement explicit and machine-readable:
package.json→"engines": { "node": ">=24 <25" }(npm warns on a mismatch).node-version→24(nodenv / asdf / fnm / mise)CONTRIBUTING.mdpoints at both and says not to develop against Node 26 CurrentWhy
verify.ymlandrelease.ymlalready pinnode-version: '24', andCONTRIBUTING.mdalready says "Node.js 24", but nothing in the repository advertises or enforces it. A contributor on Node 22 or Node 26 Current gets no signal until something fails. Node 24 is the Active LTS line, and it is also the Node that Electron 44 embeds, so the development runtime and the packaged runtime agree once that lands.Deliberately not included
Bumping the root
@types/nodefrom^22.19.7to^24. That belongs with the Electron 39 → 44 upgrade, because Electron is what determines the main process's Node runtime. Bumping the types first would let main-process code typecheck against Node 24 APIs while Electron 39 still runs Node 22 — a latent footgun for zero present benefit. I verified the bump is otherwise clean (@types/node@24.19.0, typecheck green) so it can be picked up in the Electron PR or right after it.Verified
npm run typecheck— cleannpm test— 469/469 passnpm run build— OKnpx prettier --check package.json CONTRIBUTING.md— cleanNo dependency changed, so no packaged smoke was needed; the lockfile diff is only the root package's new
enginesfield.Independence
No overlap with the sqlite-vec or Electron PRs: it touches no shared line of
package.jsonand the lockfile diff is a single root-package block.