fix(ui): restore workspace shortcuts and refine model settings - #209
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restore workspace panel shortcuts, keep citation highlights aligned when resizing the reader, and separate chat and embedding model settings.
Why?
Panel shortcuts should expand/collapse panels just like their header buttons, while opening a citation should only reveal the Library. Closing a notebook should not compete with Escape dismissal or the window-close shortcut. Reader resizing should not leave citation highlights at stale positions, and each model capability should have a dedicated settings page.
What changed?
Ctrl/Cmd+[andCtrl/Cmd+]) and remembered panel widths; citation navigation only expands the Library.Ctrl/Cmd+D. Migrate the retired Escape andCommandOrControl+Wbindings while preserving enabled state and other custom bindings.DESIGN.mdand both shortcut locales; add shortcut migration regression tests.How was this tested?
Re-run on the current PR branch:
npm run build— passed, including the requirednpm run typecheck.npm test— passed: 484 tests, no failures or skips.git diff --check main...HEAD— passed.Not yet verified: physical-keyboard workflows, visual checks,
npm run build:unpack, andnpm run smoke:packaged. Packaged-app checks are required because this PR changes Electron main-process shortcut handling. Automated checks do not establish that these runtime workflows work.Screenshots / recordings
Pending: before/after screenshots or recordings for panel toggling, reader resizing/citation highlighting, the home greeting, and the split model settings. These meaningful UI changes still need the visual evidence required by
CONTRIBUTING.md.Checklist
npm run typecheckpasses.npm run buildpasses.Desktop / build changes
npm run build:unpackpasses.npm run smoke:packagedpasses.