Skip to content

fix(ui): restore workspace shortcuts and refine model settings - #209

Merged
mrsibe merged 1 commit into
mainfrom
fix/workspace-shortcuts-and-settings
Sep 30, 2026
Merged

mrsibe merged 1 commit into
mainfrom
fix/workspace-shortcuts-and-settings

Conversation

@mrsibe

@mrsibe mrsibe commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

What does this PR do?

Restore workspace panel shortcuts, keep citation highlights aligned when resizing the reader, and separate chat and embedding model settings.

Why?

Panel shortcuts should expand/collapse panels just like their header buttons, while opening a citation should only reveal the Library. Closing a notebook should not compete with Escape dismissal or the window-close shortcut. Reader resizing should not leave citation highlights at stale positions, and each model capability should have a dedicated settings page.

What changed?

  • Restore Library/Notes panel toggles (Ctrl/Cmd+[ and Ctrl/Cmd+]) and remembered panel widths; citation navigation only expands the Library.
  • Change the default close-notebook shortcut to Ctrl/Cmd+D. Migrate the retired Escape and CommandOrControl+W bindings while preserving enabled state and other custom bindings.
  • Attach and clean up keyboard listeners immediately, and handle the new-notebook shortcut on the home page.
  • Remeasure text citation highlights on reader resize and align PDF/text reader scrollbar styling.
  • Enlarge the home greeting and split model settings into chat and embedding pages. Remove the prompt-editing entry while retaining the underlying configuration.
  • Update DESIGN.md and both shortcut locales; add shortcut migration regression tests.

How was this tested?

Re-run on the current PR branch:

  • npm run build — passed, including the required npm run typecheck.
  • npm test — passed: 484 tests, no failures or skips.
  • git diff --check main...HEAD — passed.

Not yet verified: physical-keyboard workflows, visual checks, npm run build:unpack, and npm run smoke:packaged. Packaged-app checks are required because this PR changes Electron main-process shortcut handling. Automated checks do not establish that these runtime workflows work.

Screenshots / recordings

Pending: before/after screenshots or recordings for panel toggling, reader resizing/citation highlighting, the home greeting, and the split model settings. These meaningful UI changes still need the visual evidence required by CONTRIBUTING.md.

Checklist

  • I have reviewed my own changes.
  • npm run typecheck passes.
  • npm run build passes.
  • I have tested the affected user workflow.
  • I have not included unrelated changes.
  • I have updated documentation when necessary.

Desktop / build changes

  • Not applicable
  • npm run build:unpack passes.
  • npm run smoke:packaged passes.

@github-actions github-actions Bot added the bug Something isn't working label Sep 30, 2026
@mrsibe mrsibe changed the title fix(ui): 修复面板快捷键、引用高亮并拆分模型设置 fix(ui): restore workspace shortcuts and refine model settings Sep 30, 2026
@mrsibe
mrsibe merged commit a3d5fae into main Sep 30, 2026
5 checks passed
@mrsibe
mrsibe deleted the fix/workspace-shortcuts-and-settings branch September 30, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant