Skip to content

feat: add Atlas Cloud provider - #39

Closed
binyangzhu000-sudo wants to merge 1 commit into
mrsibe:mainfrom
binyangzhu000-sudo:codex/add-atlascloud-provider
Closed

binyangzhu000-sudo wants to merge 1 commit into
mrsibe:mainfrom
binyangzhu000-sudo:codex/add-atlascloud-provider

Conversation

@binyangzhu000-sudo

Copy link
Copy Markdown

Summary

  • register Atlas Cloud as an optional built-in chat provider
  • use the OpenAI-compatible API and authenticated model discovery endpoint
  • add Atlas Cloud to the provider settings UI with English and Chinese labels
  • keep all existing defaults and providers unchanged

Validation

  • npm run typecheck:web
  • npm run lint (0 errors; existing warnings only)
  • Prettier check for all changed files
  • locale JSON parsing
  • git diff --check
  • one live Atlas Cloud Chat Completions smoke request (no retry)

npm run typecheck and npm run build remain blocked by two pre-existing missing dependencies in untouched files: nanoid in ItemService.ts and the mdast type package in MarkdownLoader.ts.

Signed-off-by: binyangzhu000-sudo <224954946+binyangzhu000-sudo@users.noreply.github.com>
@mrsibe

mrsibe commented Sep 24, 2026

Copy link
Copy Markdown
Owner

Closing this as superseded by #44, not as a rejection of the feature — Atlas Cloud support is welcome.

#44 replaced the provider registry with protocol-based model connections and deleted three of the six files this PR touches:

  • src/main/ipc/providerHandlers.ts — gone
  • src/main/providers/registry/builtinProviders.ts — gone
  • src/renderer/src/components/settings/ProvidersSettings.tsx — gone

Since Atlas Cloud is OpenAI-compatible, on the current main it no longer needs an implementation at all — it is a quick-setup preset. The whole change is a few lines in src/renderer/src/components/settings/ModelConnectionForm.tsx:

const QUICK_SETUPS: QuickSetup[] = [
  // ...
  {
    id: 'atlascloud',
    labelKey: 'presetAtlasCloud',
    protocol: 'openai-completions',
    baseUrl: 'https://api.atlascloud.ai/v1'
  }
]

plus a presetAtlasCloud label in src/renderer/src/locales/{en-US,zh-CN}/settings.json and a line in the README provider list. The protocol list itself is API_PROTOCOLS in src/shared/types/connection.ts, which also declares the embedding-capable protocols. Protocol implementations live in src/main/models/protocols/.

Two things that may help a fresh PR:

If you'd like to reopen this as a fresh PR against the current model, I'd be glad to review it — the preset approach should be around a ten-line diff.

@mrsibe mrsibe closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants