Skip to content

fix(note): stop destroying the Tiptap editor manually #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrsibe merged 1 commit into from
Sep 24, 2026
Merged

fix(note): stop destroying the Tiptap editor manually #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/renderer/src/components/notebook/note/NoteEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,9 @@ export default function NoteEditor({ content, onChange }: NoteEditorProps): Reac
}
})

// 清理编辑器实例
useEffect(() => {
return () => {
if (editor) {
editor.destroy()
}
}
}, [editor])
// 编辑器实例由 useEditor 管理生命周期（@tiptap/react v3 会在卸载时销毁），
// 这里不能手动 destroy：StrictMode 下 effect 会 mount → cleanup → mount，
// 手动销毁会让第二次挂载拿到已销毁的实例，editor.storage.markdown 为 undefined。

// 当外部 content 变化时同步到编辑器
useEffect(() => {
Expand Down
Loading