Open
Conversation
Owner
|
Unfortunately this removes a lot of custom changes (which admittedly need to be written as a separate patch) needed for cross-platform compatibility. Is there a particular reason you need 5.38 at the moment? |
Author
|
i suspected this so no urgency, i discovered that detecting .xlsx files can only be done with recent libmagic, with 5.38 it works fine as the file utility. i had to switch to run the file to detect Excel files for now but this is just FYI, at least it works without crashing |
|
check sharekey#1 for fix of the issue of false detection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.