Skip to content

Fix discrepancy in GHS inline algorithm by reusing reclustering results#4

Open
mseidel42 wants to merge 1 commit intoDev-GHS-Algofrom
fix/ghs-inline-reclustering-18152557605028156089
Open

Fix discrepancy in GHS inline algorithm by reusing reclustering results#4
mseidel42 wants to merge 1 commit intoDev-GHS-Algofrom
fix/ghs-inline-reclustering-18152557605028156089

Conversation

@mseidel42
Copy link
Copy Markdown
Owner

Fix discrepancy in GHS inline algorithm by reusing reclustering results

The "inline" implementation of the GHS flavour algorithm was previously reconstructing fastjet::PseudoJet objects from scratch, which lost crucial substructure and clustering history compared to the "full" implementation. This commit updates the inline implementation to reuse the already reclustered jets (inclusiveJets) using reclusteredIndices. This ensures both methods produce consistent results and efficiently reuses the existing reclustering step used for CMS jet flavour definitions.


PR created automatically by Jules for task 18152557605028156089 started by @mseidel42

The "inline" implementation of the GHS flavour algorithm was previously reconstructing `fastjet::PseudoJet` objects from scratch, which lost crucial substructure and clustering history compared to the "full" implementation. This commit updates the inline implementation to reuse the already reclustered jets (`inclusiveJets`) using `reclusteredIndices`. This ensures both methods produce consistent results and efficiently reuses the existing reclustering step used for CMS jet flavour definitions.

Co-authored-by: mseidel42 <1311783+mseidel42@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant