Dashboards: drop expandOthers and showTotal from bar and column components - #5
Merged
Merged
Conversation
…nents Neither property does anything on a Bar, Column or ColumnStacked component, which is why a retrieve flipped one and dropped the other. The three Donut components keep both, where they mean something: showTotal puts the total in the centre of the ring and expandOthers decides whether the grouped 'Others' slice can be opened. 28 elements removed across the three dashboards; every file still parses. The docs note now says which component types the two properties belong to. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XsipTUqX7dcQDkvUkaFCuC
mshresponse
marked this pull request as ready for review
September 14, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed
<expandOthers>and<showTotal>from every Bar, Column and ColumnStacked component in the three dashboards (28 elements acrossNZC_Audit,NZC_Data_QualityandNZC_Emissions_Coverage). Neither property does anything on those chart types, which is why a retrieve flipped one tofalseand dropped the other.The three Donut components keep both properties, where they mean something:
showTotalputs the total in the centre of the ring, andexpandOthersdecides whether the grouped "Others" slice can be opened.docs/building-your-own.mdnow says which component types the two properties belong to, so a new component gets them only when it is a donut or pie.Checks
🤖 Generated with Claude Code
https://claude.ai/code/session_01XsipTUqX7dcQDkvUkaFCuC
Generated by Claude Code