Skip to content

Separators in purity ploidy are inconsistent with the #51

Description

@kevinmhadi

Describe the bug
@xanthopoulakis - We need to correct the formula for the red dotted separators in the purity ploidy histogram (Segment Width Distribution). The meaning of the slope and intercept for these are slightly different.

I believe the issue is this expression:

    let separators = d3
      .range(0, maxSeparatorsCount + 1)
      .map((i) => slope * i + intercept);

Below is the pseudocode of the right parameters to use and the final expression:

a = 2 * (1-purity) / 2
b = 1 / beta
ppfit_intercept = a / b
ppfit_slope = beta
ppfit_slope * i + ppfit_intercept

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghigh priority / sprinthigh priority items or aligned with week's sprintholdspec needs to be updated

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions