PR #10 split: vendored ImGui launcher (SUPERSEDED by recomp-ui) - #11
Closed
mstan wants to merge 1 commit into
Closed
PR #10 split: vendored ImGui launcher (SUPERSEDED by recomp-ui)#11mstan wants to merge 1 commit into
mstan wants to merge 1 commit into
Conversation
Broken out of PR #10 (navjack). Vendors the Dear ImGui core (1.92.9 WIP, core + SDL2/OpenGL3 backends only — demo/examples/docs not imported) under third_party/imgui and replaces snesrecomp_target_launcher_ng() with a local mmx_target_launcher_ng() that builds the engine's launcher C sources against this repo's ImGui copy. The engine launcher bundles 1.91.9b; platform UI backends added on top of this (Metal, SDL_Renderer2) need the newer API, and linking both copies would create duplicate symbols. Also sets CXX/C++17 on the CMake project, which the vendored backends need. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Closing as superseded by recomp-ui integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the PR #10 breakup (navjack, "Add macOS/Linux support, true widescreen, and Steam Deck validation"). Original authorship preserved.
What this is
The vendored-Dear-ImGui launcher approach from PR #10: bundles ImGui (core + SDL2 + GL3) directly into the game tree and provides a local
mmx_target_launcher_ng()replacing the engine'ssnesrecomp_target_launcher_ng(the in-engine launcher bundled ImGui 1.91.9b, causing a duplicate-symbol conflict).Disposition: SUPERSEDED — not for merge
The launcher has since moved out of the game/engine entirely into the shared, console-agnostic
recomp-uirepo, consumed as a submodule.mainnow builds the recomp-ui launcher on every platform (CMake/mingw and the MSVCmmx.sln), so the in-tree vendored-launcher approach here is obsolete.Kept open as a reference/discussion artifact for the PR #10 close-out. The problem it solved (ImGui version collision) is solved differently now: recomp-ui vendors its own ImGui and namespaces its public symbols (
recompui_*) so it coexists with the engine's helpers.Base is
mainfor a clean diff; no merge intended.