PR #10 split: Linux in-game ImGui menu (SUPERSEDED by recomp-ui) - #12
Closed
mstan wants to merge 2 commits into
Closed
PR #10 split: Linux in-game ImGui menu (SUPERSEDED by recomp-ui)#12mstan wants to merge 2 commits into
mstan wants to merge 2 commits into
Conversation
Broken out of PR #10 (navjack). Vendors the Dear ImGui core (1.92.9 WIP, core + SDL2/OpenGL3 backends only — demo/examples/docs not imported) under third_party/imgui and replaces snesrecomp_target_launcher_ng() with a local mmx_target_launcher_ng() that builds the engine's launcher C sources against this repo's ImGui copy. The engine launcher bundles 1.91.9b; platform UI backends added on top of this (Metal, SDL_Renderer2) need the newer API, and linking both copies would create duplicate symbols. Also sets CXX/C++17 on the CMake project, which the vendored backends need. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Broken out of PR #10 (navjack). Adds src/linux_ui.{cpp,h}: a Dear ImGui overlay for the Linux/Steam Deck runtime with F1 toggle, widescreen enable/active status, and save/load-state slot controls. Renders through either the SDL_Renderer2 or OpenGL3 ImGui backend to match the active output method; keyboard focus is captured while the menu is open. Stacked on pr10/widescreen (MmxDisplay_* API) and the vendored ImGui commit (backends). Note for review: F1 collides with the default LoadState slot-1 binding; on Linux the menu toggle now wins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the PR #10 breakup (navjack, "Add macOS/Linux support, true widescreen, and Steam Deck validation"). Original authorship preserved.
What this is
The Linux in-game F1 Dear ImGui menu from PR #10 (SDL + OpenGL output backends): a toggleable in-game overlay exposing the widescreen switch and Save/Load buttons for all ten savestate slots. Stacked on
pr10/imgui-vendor-launcher(its commits appear here too, since neither is inmain).Disposition: SUPERSEDED — not for merge
The UI layer is now owned by the shared
recomp-uilauncher, which is console-agnostic and universal across platforms — the same UI serves Windows, Linux, and macOS rather than a Linux-specific in-game menu. An in-game (mid-play) overlay on top of recomp-ui is a possible future feature, but this specific implementation is tied to the retired in-tree launcher_ng.Kept open as a reference/discussion artifact for the PR #10 close-out. Base is
main; no merge intended.