Skip to content

Fix Linux FMV bank verification - #10

Merged
mstan merged 1 commit into
mstan:mainfrom
MysteriousAeon:fix/linux-fmv-bank-check
Aug 23, 2026
Merged

Fix Linux FMV bank verification#10
mstan merged 1 commit into
mstan:mainfrom
MysteriousAeon:fix/linux-fmv-bank-check

Conversation

@MysteriousAeon

Copy link
Copy Markdown
Contributor

Fixes #8.

tools/build-linux.sh enables pipefail and previously checked for the FMV runtime bank with:

strings "$BIN" | grep -q mph_arm9_fmv_runtime

When grep -q finds a match, it exits early and strings can receive SIGPIPE. With pipefail enabled, that makes the pipeline return 141 even though the runtime bank is present.

This replaces the pipeline with a direct binary search:

grep -a -q mph_arm9_fmv_runtime "$BIN"

Verified locally:

old check: 141
new check: 0
bash -n: 0
git diff --check: 0

The change is limited to one line in tools/build-linux.sh.

@mstan
mstan merged commit 818cb98 into mstan:main Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux build falsely reports missing FMV runtime bank due to pipefail + grep -q

2 participants