Skip to content

Show errors for missing or unsupported ROMs - #9

Merged
mstan merged 1 commit into
mstan:mainfrom
MysteriousAeon:fix/rom-validation-error
Aug 23, 2026
Merged

Show errors for missing or unsupported ROMs#9
mstan merged 1 commit into
mstan:mainfrom
MysteriousAeon:fix/rom-validation-error

Conversation

@MysteriousAeon

Copy link
Copy Markdown
Contributor

Fixes #6.

This adds visible ROM validation errors instead of silently exiting when the expected ROM is missing or unsupported.

Changes:

  • Windows launcher now shows an error when no ROM is selected, the ROM cannot be opened, or its SHA-1 does not match the supported USA revision 0 dump.
  • Linux AppImage startup now shows a desktop error dialog when no .nds file is found or when the detected ROM has the wrong SHA-1.
  • Explicit runner arguments on Linux remain unchanged.

Tested on Linux AppImage:

  • No ROM: error dialog shown.
  • Wrong ROM: unsupported-ROM error dialog shown.
  • Correct ROM: game launches normally.

git diff --check passes and the change is limited to launcher/recomp-ui/launcher_main.cpp and tools/build-linux.sh.

@mstan
mstan merged commit 2f3cbb2 into mstan:main Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Silent Shutdown on first start

2 participants