Skip to content

fix: revert destructive PR #87 runtime merge - #90

Merged
mstan merged 1 commit into
masterfrom
codex/fix-pr87-regressions-20260731
Jul 31, 2026
Merged

fix: revert destructive PR #87 runtime merge#90
mstan merged 1 commit into
masterfrom
codex/fix-pr87-regressions-20260731

Conversation

@mstan

@mstan mstan commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • revert the destructive PR Feat/UI 5p #87 merge as one coherent unit instead of restoring only its currently-visible symptoms
  • keep the current lib/recomp-net pin and game-owned recomp-ui architecture
  • retain compatibility with the current recomp-ui netplay callback ABI
  • update stale packaging/controller lifecycle tests for the current ownership and activation model

Why

PR #87 merged a stale runtime snapshot over master. Current master lost trusted mod API implementations and several previously-shipped behaviors, fails five registered tests, and cannot link current Tomba.

Validation

  • recompiler build: PASS
  • CTest: 34/34 PASS
  • current Tomba + current game-owned recomp-ui native link: PASS
  • BIOS regeneration: OpenBIOS 650 emitted; SCPH-1001 1310 emitted

After this lands, PR #85 registers the two currently-built orphan tests, bringing the suite to 36.

This reverts commit e01347c, reversing
changes made to 60cb60e.
@mstan
mstan merged commit ba37110 into master Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant