[WIP] streaming graph walk transition#97
Open
NSagan271 wants to merge 16 commits into
Open
Conversation
88ab350 to
9830d30
Compare
…LS and erroneously resetting the step metadata
0c5e9c0 to
1475c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a producer partition drive a consumer's graph-walk transitions via the data stream, instead of the conductor centrally advancing them. This decouples a consumer's walk from the conductor's (lagging) view and enables PD disaggregation of the qwen3-omni Talker.
Mechanism
PartitionDefinition.transition_source(STATE_MACHINEvsPRODUCER_TRIGGERED) declares who owns a partition's walk.Connection.consumer_walk_transitioncallback maps streamed items toWalkTransitionmarkers; the consumer'sStreamBuffercuts a chunk boundary at each transition so a walk never straddles two chunks.produced_edge_idx/consumed_edge_idxcounters round-trip through the conductor; index-based dedup (first-arrival-wins) + monotonic set_index keep the stream continuous across the prefill→decode worker seam (PD).thinker_statescarrying the markers; prefill states keep the Talker intalker_prefill(KV extend), the firstthinker_decodestate flips it totalker_last_prefill, then the second decode state causes a transition totalker_decode. New configs/qwen3omni_talker_pd_disag.yaml splits the Talker across prefill/decode workers.Touches conductor/, streaming/, worker/, graph/, qwen3-omni model.
Testing
Testing in progress; tested on default qwen3 omni config, 2-GPU, thinker TP2, and a new
configs/qwen3omni_talker_pd_disag.yamlsplits both the Thinker and Talker across prefill/decode workers.