feat(parser): add Erlang/OTP parser for app.src, rebar.config, rebar.lock#762
Merged
feat(parser): add Erlang/OTP parser for app.src, rebar.config, rebar.lock#762
Conversation
…lock Add net-new Erlang/OTP package metadata support with three parsers backed by a native Erlang term parser. No Python ScanCode reference exists for this ecosystem. Signed-off-by: Maxim Stykow <stykowmaxim@meta.com>
Keep map-bearing OTP metadata from falling back and preserve real Hex package identity for aliased rebar dependencies. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Lock in the rebar.config plus rebar.lock contract so dependency hoisting and assembly output stay stable across refactors. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Document the map, alias, and git_subdir behavior shipped with the parser fixes so the improvement notes stay aligned with the code. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Strip bounded %PLACEHOLDER% macro runs outside strings so canonical OTP app.src templates keep parsing while weak bare-word GPL hits remain clue-only evidence. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Record the ejabberd, OTP, and VerneMQ compare runs, regenerate the benchmark chart, and mark scorecard row 44 verified after triaging the remaining deltas. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
94c3318 to
da94654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.app.src,rebar.config, andrebar.lock, including map-aware metadata handling, alias-aware Rebar package identity, and bounded%PLACEHOLDER%template parsing for canonical OTP manifests such asdiameter.app.srccompare-outputsagainstprocessone/ejabberd,erlang/otp, andvernemq/vernemq, then record benchmark rows and mark the row🟢 VerifiedIssues
Scope and exclusions
*.app.srcparsing for OTP application metadata, stdlib-filtered dependencies, runtime dependency extraction, and template-placeholder resiliencerebar.configparsing for Hex, git, alias, and profile-scoped dependenciesrebar.lockparsing for resolved package identity, git refs, and hash coveragerebar.config+rebar.lockdocs/SUPPORTED_FORMATS.md,docs/implementation-plans/package-detection/PARSER_PLAN.md,docs/BENCHMARKS.md, anddocs/benchmarks/scan-duration-vs-files.svg.provenant/compare-runs/20260422T183347Z-ejabberd-26578.provenant/compare-runs/20260422T182619Z-otp-15523.provenant/compare-runs/20260422T182920Z-vernemq-20484{if_var_true, ...}stay skipped instead of being guessed atIntentional differences from Python
gpl_bare_word_only.RULEstays demoted to clue evidence; OTP triage confirmed that stronger GPL and GPL-with-exception findings still surface as detections rather than being demoted with itFollow-up work
Expected-output fixture changes
testdata/erlang-otp-golden/*.expected,testdata/assembly-golden/erlang-otp-basic/expected.json%PLACEHOLDER%parser fix required no further golden updates