Cygwin: align testsuite tmp directory with runtime path resolution#343
Open
aswin-mcw wants to merge 1 commit into
Open
Cygwin: align testsuite tmp directory with runtime path resolution#343aswin-mcw wants to merge 1 commit into
aswin-mcw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cygwin: align testsuite tmp directory with runtime path resolution
Summary
While investigating Cygwin testsuite failures in MSYS2, I found that the installation root was being resolved one directory too far back in my build layout.
In
init_cygheap::init_installation_root()(winsup/cygwin/mm/cygheap.cc), the__MSYS__logic strips three directory levels in total when determining the installation root. For my test environment, this resulted in incorrect path resolution.The testsuite was also creating temporary files under
${builddir}/testinst/tmp. Changing it to use${builddir}/tmpaligns the test layout with the runtime's expected path resolution.Results
After making this change, the winsup testsuite results improved significantly in my environment:
This suggests that a large number of failures were caused by path resolution and test layout issues rather than individual runtime failures.