Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an early draft implementing snapshot tests to validate the visual output of oneway and twoway tables. Maybe it's a bit overkill, but I thought it was worth exploring.
There are many options available when creating a table and therefore many different kinds of tables can be produced. The parameterized snapshots in this draft are aimed at testing some of the possible variations (currently only boolean options).
It would have been ideal to use HTML for the snapshot files, but the HTML output offlextableuses randomized class names which breaks the tests. I haven't found a way to control that so for now I went with PNG instead. The main drawback is that captions cannot be included in PNG output.I still need to add snapshot tests for
GTtables as well as tests targeting the internals.