Export stop_times.stop_sequence

[mmathieum]

• Export stop_times.stop_sequence commons-java#25

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the data model and export capabilities by integrating the stop_sequence from GTFS stop_times data. By incorporating this field into the MSchedule object and the database utility, the system can now maintain and export the precise order of stops within a trip, which is crucial for accurate schedule processing and display in transit applications.

Highlights

• Data Model Enhancement: Added a new stopSequence property to the MSchedule data class to store the stop order within a trip.
• Database Integration: Updated DBUtils to include the stop_sequence column in the schedule database table definition and to correctly retrieve this data.
• Conditional Data Export: Implemented logic to conditionally export the stopSequence value based on the FeatureFlags.F_EXPORT_STOP_SEQUENCE flag, allowing for flexible control over data output.

Changelog

• src/main/java/org/mtransit/parser/db/DBUtils.kt
  • Added stop_sequence column to the schedule table definition.
  • Updated the MSchedule object creation to retrieve the stop_sequence from the database result set.
• src/main/java/org/mtransit/parser/mt/data/MSchedule.kt
  • Introduced stopSequence as a new property in the MSchedule data class.
  • Modified the primary and secondary constructors to accept and initialize the stopSequence.
  • Added logic to conditionally include the stopSequence in the exported schedule data based on the FeatureFlags.F_EXPORT_STOP_SEQUENCE flag.
  • Defined STOP_SEQUENCE as a constant for the column name.

Activity

• No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the stop_sequence to the exported data. While no security vulnerabilities were identified, a critical functional bug was found: the insertSchedule function in DBUtils.kt was not updated to reflect the new table schema, specifically missing the stop_sequence column, which will cause runtime SQL errors. The other changes in MSchedule.kt and the table creation and selection in DBUtils.kt are mostly correct.