Skip to content

⚡ Bolt: Flatten matrixMultiply for faster color conversion #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mttmcknn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Flatten matrixMultiply for faster color conversion #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@
## 2024-05-10 - Optimize Math Operations with Lookup Tables
**Learning:** When mathematical operations depend strictly on a small, discrete domain (e.g., converting 8-bit color components 0..255 from sRGB to linear space), utilizing pre-computed arrays or lookup tables instead of redundant on-the-fly computation (divisions, conditionals, `.pow()`) significantly improves performance in hot paths (over 20x improvement).
**Action:** Identify finite input domains in hot paths and pre-calculate their results into arrays (like `DoubleArray(256)`) instead of doing continuous computations repeatedly.

## 2024-08-11 - Unpack Matrix Elements for KMP Hot Paths
**Learning:** In KMP hot paths (e.g. math operations in color conversion like `matrixMultiply`), explicitly unpacking inner arrays and elements into local variables (like `row[0]`, `matrix[1]`, etc.) avoids multiple array dereferences and bounds checks per operation. This yields a significant performance gain (around 1.5x to 2x speedup).
**Action:** When working with 2D arrays or repeated array index lookups inside a hot loop in KMP, unpack those values into local primitives to avoid JVM/JS bounds checking overheads when flattening the array signature isn't feasible.
12 changes: 9 additions & 3 deletions halogen-core/src/commonMain/kotlin/halogen/color/MathUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,15 @@ internal object MathUtils {
180.0 - abs(abs(a - b) - 180.0)

fun matrixMultiply(row: DoubleArray, matrix: Array<DoubleArray>): DoubleArray {
val a = row[0] * matrix[0][0] + row[1] * matrix[0][1] + row[2] * matrix[0][2]
val b = row[0] * matrix[1][0] + row[1] * matrix[1][1] + row[2] * matrix[1][2]
val c = row[0] * matrix[2][0] + row[1] * matrix[2][1] + row[2] * matrix[2][2]
val r0 = row[0]
val r1 = row[1]
val r2 = row[2]
val m0 = matrix[0]
val m1 = matrix[1]
val m2 = matrix[2]
val a = r0 * m0[0] + r1 * m0[1] + r2 * m0[2]
val b = r0 * m1[0] + r1 * m1[1] + r2 * m1[2]
val c = r0 * m2[0] + r1 * m2[1] + r2 * m2[2]
return doubleArrayOf(a, b, c)
}
}
Loading