Conversation
Replaces the direct `http.Get` call with a custom `http.Client` that mitigates SSRF by explicitly blocking access to the cloud metadata endpoint (169.254.169.254) using a dialer Control hook. The fix clones the default transport to avoid dropping other default configs. Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Server-Side Request Forgery (SSRF) was possible in the
addFromDirectURLfunction of the plugin manager, which directly calledhttp.Get()on untrusted, user-provided URLs.🎯 Impact: An attacker could potentially supply a crafted URL that caused the application to make internal requests to private endpoints, such as cloud metadata services (e.g., AWS IMDS), exposing sensitive configuration or tokens.
🔧 Fix: Replaced the unconfigured
http.Get()with a customhttp.Client. The client now clones thehttp.DefaultTransportand uses aDialContexthook innet.Dialerto inspect the resolved IP before the connection is established. It explicitly blocks connections to the well-known metadata IP169.254.169.254. A 10-second timeout was also added.✅ Verification: Verified by attempting to download a plugin from
http://169.254.169.254. The connection is successfully rejected with an "SSRF blocked" error message, as confirmed via scratchpad tests and no regressions observed ingo test ./....PR created automatically by Jules for task 12196599876244834665 started by @himattm