Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix SSRF in plugin manager - #238

Open
mttmcknn wants to merge 1 commit into
mainfrom
sentinel-fix-ssrf-3167999634774808332
Open

mttmcknn wants to merge 1 commit into
mainfrom
sentinel-fix-ssrf-3167999634774808332

Conversation

@mttmcknn

@mttmcknn mttmcknn commented Aug 5, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Server-Side Request Forgery (SSRF). The addFromDirectURL function used http.Get() with user-provided URLs without validating the resolved IP address.
🎯 Impact: An attacker could provide a URL that resolves to the cloud metadata endpoint (169.254.169.254), potentially exposing sensitive cloud credentials or instance metadata.
πŸ”§ Fix: Replaced http.Get() with a custom http.Client and net.Dialer. The dialer uses a Control hook to check the resolved IP after DNS resolution but before the connection is made, explicitly blocking the cloud metadata IP. Also added a 10s timeout to prevent DoS.
βœ… Verification: Verified by attempting to download a plugin from http://169.254.169.254/latest/meta-data/ with the updated code, which correctly returned an "access to cloud metadata IP is forbidden" error. Also ran go test ./... to ensure no regressions were introduced.


PR created automatically by Jules for task 3167999634774808332 started by @himattm

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant