Conversation
Replaced vulnerable direct `http.Get()` calls in `internal/plugin/manager.go` with a custom `secureHTTPClient`. This new client enforces HTTP request timeouts to prevent resource exhaustion and utilizes a `net.Dialer` control hook to rigorously block DNS resolution of the cloud metadata IP (169.254.169.254), protecting against Server-Side Request Forgery. Keep-alives were also disabled to prevent connection leaks for one-off requests. Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability:
http.Get()was used directly for fetching plugins from user-supplied URLs without mitigating SSRF targeting cloud metadata IP (169.254.169.254).π― Impact: An attacker could coerce the application to fetch sensitive metadata from cloud environments via SSRF.
π§ Fix: Created and utilized a custom
http.Clientwith anet.Dialercontrol hook that strictly blocks access to the169.254.169.254metadata IP during DNS resolution before the socket connects. Explicitly disabled keep-alives and configured timeouts to prevent resource exhaustion.β Verification: Verified that
go test ./...passes andgo build ./...compiles successfully.PR created automatically by Jules for task 13606388046376229231 started by @himattm