Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Server-Side Request Forgery (SSRF) - #242

Open
mttmcknn wants to merge 1 commit into
mainfrom
sentinel-ssrf-fix-10610290995065135935
Open

mttmcknn wants to merge 1 commit into
mainfrom
sentinel-ssrf-fix-10610290995065135935

Conversation

@mttmcknn

@mttmcknn mttmcknn commented Aug 7, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Unrestricted use of http.Get() inside addScriptPlugin and addFromDirectURL allows an attacker to make server-side HTTP requests, including hitting cloud metadata APIs (like 169.254.169.254).
🎯 Impact: If exploited, an attacker could extract sensitive infrastructure credentials or data by making requests to internal IPs.
πŸ”§ Fix: Created a safeHTTPClient() using a custom net.Dialer with a Control hook to reject resolved IPs matching known sensitive internal IPs, and replaced http.Get calls to use this custom client.
βœ… Verification: Ensured the plugin can still be fetched from GitHub correctly via normal workflows, but direct requests pointing to cloud metadata IPs will throw a dial error.


PR created automatically by Jules for task 10610290995065135935 started by @himattm

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant