Conversation
Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Unrestricted use of
http.Get()insideaddScriptPluginandaddFromDirectURLallows an attacker to make server-side HTTP requests, including hitting cloud metadata APIs (like169.254.169.254).π― Impact: If exploited, an attacker could extract sensitive infrastructure credentials or data by making requests to internal IPs.
π§ Fix: Created a
safeHTTPClient()using a customnet.Dialerwith aControlhook to reject resolved IPs matching known sensitive internal IPs, and replacedhttp.Getcalls to use this custom client.β Verification: Ensured the plugin can still be fetched from GitHub correctly via normal workflows, but direct requests pointing to cloud metadata IPs will throw a dial error.
PR created automatically by Jules for task 10610290995065135935 started by @himattm