Conversation
…wnloads Replaced usage of `http.Get` for fetching user-provided plugin URLs with a custom `http.Client`. The new client (`newSafeHTTPClient`) includes an explicitly configured `net.Dialer` with a `Control` hook that intercepts socket connections *after* DNS resolution to evaluate the actual IP address being connected to. This blocks access to specific targeted cloud metadata endpoints (like 169.254.169.254), protecting against DNS rebinding and IP obfuscation SSRF attacks. Also introduces explicit timeouts for these external requests. Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
http.Getwas used directly for downloading plugins, allowing potential SSRF against cloud metadata endpoints.newSafeHTTPClientwith a customDialContexthook that blocks connections to169.254.169.254.go test ./...) and ensuring build completion.PR created automatically by Jules for task 6205668168245219430 started by @himattm