Conversation
Adds a custom net.Dialer with a Control hook to prevent HTTP requests from resolving to internal cloud metadata IP addresses when downloading plugins via untrusted URLs. Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The plugin manager passed untrusted user-provided URLs (via
addFromDirectURLandaddScriptPlugin) directly tohttp.Get(). While URL schemes were restricted tohttpandhttps, the resolved IP addresses were not verified. This allowed an attacker to supply a URL that resolves to a sensitive cloud metadata IP address (e.g.,169.254.169.254), leading to a Server-Side Request Forgery (SSRF) vulnerability.π― Impact: An attacker could coerce the application into making unauthorized HTTP requests to internal cloud provider endpoints, potentially leaking temporary credentials, instance metadata, or other sensitive configuration details.
π§ Fix: Replaced
http.Get()with a customhttp.Client(createSafeClient()). This client utilizes anet.Dialerwith aControlhook that intercepts the connection after DNS resolution but before the socket is dialed. The hook parses the resolved IP address and explicitly blocks connections to known cloud metadata IP ranges (169.254.169.254).β Verification: The fix can be verified by running
go test ./...to ensure no regressions, and by manually providing a URL to the plugin manager that resolves to169.254.169.254; the request should immediately fail with a "blocked cloud metadata IP" error before any data is sent.PR created automatically by Jules for task 16066449967481407555 started by @himattm