Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) vulnerability - #251

Open
mttmcknn wants to merge 1 commit into
mainfrom
sentinel-fix-ssrf-11926236194630636081
Open

mttmcknn wants to merge 1 commit into
mainfrom
sentinel-fix-ssrf-11926236194630636081

Conversation

@mttmcknn

Copy link
Copy Markdown
Owner
  • 🚨 Severity: HIGH
  • πŸ’‘ Vulnerability: The plugin manager uses http.Get and standard http.Client for fetching plugins from URLs provided by the user, and does not restrict requests to sensitive local IPs like cloud metadata endpoints.
  • 🎯 Impact: An attacker could coerce the application to send HTTP requests to sensitive internal networks, such as cloud metadata APIs (169.254.169.254), potentially exposing credentials or internal services.
  • πŸ”§ Fix: Implemented newSafeClient which uses a custom net.Dialer with a Control hook to inspect the resolved IP address before connection and explicitly blocks access to 169.254.169.254. Replaced http.Get and standard http.Client usages with this safe client.
  • βœ… Verification: Tested successfully with go test ./... and go build ./....

PR created automatically by Jules for task 11926236194630636081 started by @himattm

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant