Conversation
Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
http.Getand standardhttp.Clientfor fetching plugins from URLs provided by the user, and does not restrict requests to sensitive local IPs like cloud metadata endpoints.169.254.169.254), potentially exposing credentials or internal services.newSafeClientwhich uses a customnet.Dialerwith aControlhook to inspect the resolved IP address before connection and explicitly blocks access to169.254.169.254. Replacedhttp.Getand standardhttp.Clientusages with this safe client.go test ./...andgo build ./....PR created automatically by Jules for task 11926236194630636081 started by @himattm