Allow providers to provide completions based on raw query text#1502
Merged
gjsjohnmurray merged 5 commits intomtxr:devfrom Apr 19, 2026
Merged
Conversation
05fa463 to
d8f649f
Compare
Collaborator
|
This looks good. Have you verified it by building a driver that uses it? |
Contributor
Author
|
@gjsjohnmurray, I didn't build a new driver per se, I modified the postgres one to return some hardcoded completions and it was working fine. |
ItejahatDeliveryServices
approved these changes
Oct 30, 2025
ItejahatDeliveryServices
approved these changes
Oct 30, 2025
ItejahatDeliveryServices
approved these changes
Oct 30, 2025
ItejahatDeliveryServices
approved these changes
Oct 30, 2025
ItejahatDeliveryServices
approved these changes
Oct 30, 2025
gjsjohnmurray
requested changes
Apr 14, 2026
Collaborator
gjsjohnmurray
left a comment
There was a problem hiding this comment.
Thanks for the contribution, and sorry for the delay. One tweak suggested to a log message. Then I think we should merge this and watch for a driver developer to leverage it.
Co-authored-by: John Murray <johnm@georgejames.com>
gjsjohnmurray
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a way for different providers to provide completions based on raw query text and current cursor.
The motivation is that some drivers can use SQL dialect not supported by Hue. In these cases, Hue fails to provide any completions at all, for example: #1453 .
It seems reasonable to allow these rare drivers to opt out of using Hue and take burden of parsing the query and providing completions by themselves.
Thank you for your contribution!
Before submitting this PR, please make sure: