Fix reconnection race in golf websocket server#1154
Merged
Conversation
Restructure reconnectPlayer to return restore data instead of spawning a goroutine with a 10ms sleep. handleAuthenticate now sends authenticated, roomJoined, and gameJoined messages synchronously after releasing the lock, eliminating the window where a client could act before receiving its restored state. Fixes #1152
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 4d27ca8 | Commit Preview URL Branch Preview URL |
Apr 12 2026, 06:33 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure reconnectPlayer to return restore data instead of spawning a goroutine with a 10ms sleep. handleAuthenticate now sends authenticated, roomJoined, and gameJoined synchronously after releasing the lock, eliminating the window where a client could act before receiving its restored state.
Closes #1152