Conversation
Member
Author
|
This PR is dedicated to @benkmugo |
Member
Author
|
Upstream PR unlikely to get any attention: ezsystems#223 |
benkmugo
approved these changes
Nov 12, 2021
Member
benkmugo
left a comment
benkmugo
left a comment
There was a problem hiding this comment.
Very nice, especially re-using the same approach as updateNodeVisibility to avoid timeouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, eZ Find does not re-index a node's subtree when the node is moved. This PR uses the same strategy that we use when the node's visibility is toggled, which is to defer the re-index to the ezfindindexsubtree cronjob.