[react] Use React 15.5 and prop-types lib by rsolomon · Pull Request #6577 · mui/material-ui

rsolomon · 2017-04-11T20:56:59Z

Use new prop-types lib instead of the deprecated React.PropTypes.

Note that the react-title-component lib references in docs still uses React.PropTypes, so you'll still get the error there.

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

rsolomon · 2017-04-11T21:32:08Z

I think this might be blocked until Enzyme releases an update. Relevant PR is here, but it hasn't yet been released.

mbrookes · 2017-04-11T21:36:47Z

Thanks for taking this on. 👍

oliviertassinari · 2017-04-11T21:49:44Z

As any responsible developers, we treat warning as error in our test suite thanks to test/utils/consoleError.js. I have been commenting out that logic on the next branch.
I'm not against doing so on the master branch, waiting for the warning to be fixed in our dependencies.

rsolomon · 2017-04-11T22:39:38Z

@oliviertassinari I commented out the relevant bits and slapped a comment in there. Let me know if there's anything else I can do to prep this PR.

Note also that we'll still be seeing deprecation warnings in docs until this or this PR merges for react-document-title. It's also an option to switch to the more actively maintained react-document-title, but it's also waiting on a pull request to bring it up to date.

mbrookes · 2017-04-11T22:47:26Z

@rsolomon Sorry about the merge conflict. Thanks for the quick turnround!

oliviertassinari

@rsolomon Thanks for updating the PR. Some last comments.

oliviertassinari · 2017-04-12T11:52:41Z

docs/src/app/app.native.js

@@ -1,4 +1,6 @@
-import React, {Component, PropTypes} from 'react-native';
+import React, {Component} from 'react-native';
+


Minor issue, we have quite some blank lines added by this PR between the imports.

oliviertassinari · 2017-04-12T11:53:20Z

package.json

-    "react-dom": "^15.4.0",
+    "react": "^15.5.0",
+    "react-dom": "^15.5.0",
+    "react-prop-types": "^15.5.0",


I think that it should be a dependency. No need to worry about conflicts.

For instance: reduxjs/react-redux#663.

It should be a dependency.

The package is called prop-types, not react-prop-types.

😰 Yikes, thanks for catching.

gaearon · 2017-04-12T13:55:16Z

package.json

-    "react-dom": "^15.4.0",
+    "react": "^15.5.0",
+    "react-dom": "^15.5.0",
+    "react-prop-types": "^15.5.0",


It should be a dependency.

The package is called prop-types, not react-prop-types.

gaearon · 2017-04-12T16:31:11Z

package.json

    "keycode": "^2.1.8",
    "lodash.merge": "^4.6.0",
    "lodash.throttle": "^4.1.1",
+    "prop-types": "^15.5.0",


Please use ^15.5.7. There are critical known issues in earlier versions.

rsolomon · 2017-04-12T19:29:56Z

@oliviertassinari the whitespace and dependency issues should be good to go. Let me know if there's anything I can do to help

oliviertassinari

That looks almost good to me 👍 .

Also noticed that you left the docs/package.json untouched. We can do that in another PR.

oliviertassinari · 2017-04-12T21:16:09Z

package.json

-    "react": "^15.4.0",
-    "react-dom": "^15.4.0",
+    "react": "^15.5.0",
+    "react-dom": "^15.5.0",


Can we stick to the older versions? I don't think that we need to upgrade the requirement. We would have to release a minor instead of a patch otherwise.

"react": "^15.4.0", "react-dom": "^15.4.0",

Ah you're right for the peerDependencies. I do think you'll want to keep the dependencies (though I think in this case they should be devDependencies, but I don't have any historical context here) to 15.5.0 for react-dom because this diff uses react-dom/test-utils, which was a recent migration.

Just want to confirm with you before I make the change.

You are referring to the following dependencies:

+ "react-addons-create-fragment": "^15.5.0", + "react-addons-transition-group": "^15.5.0",

Same, I don't think that we need to update those. If we do, let's release a minor.

rsolomon · 2017-04-13T17:28:41Z

@oliviertassinari Some quick notes on the last update:

I've reverted the peerDependencies back to 15.4.0, as no changes to the non-test code were made that necessitate an update.
For tests to pass without warnings, we have to pull TestUtils from the react-dom package, which was added in 15.5.0. This version of react-dom requires its peer React be of version ^15.5.0 as well, so that was bumped in devDependencies as well.
I was able to upgrade Enzyme to get rid of the need to comment out the warning -> error module, but it depends on react-dom@^15.5.0, so it will play a role in deciding what to do.

I'm not completely comfortable setting the devDependencies higher than the actual deployable module dependencies, but I'm not sure if that's a dealbreaker or not. If it is, we have a few options:

Keep everything in both dependencies and devDependencies to ^15.4.0. This will remove warnings from the module itself. Unfortunately the tests will need to depend on the deprecated react-addons-test-utils. That has the implication of having both the material-ui tests and the Enzyme dependency throw deprecation warnings, requiring us to keep the throw on warning code commented out.
Update all dependencies to ^15.5.0, requiring a minor version bump (hey, 18 is a lucky number in some cultures I'm sure!)
Keep the dependency versions higher for development than for actual deployment. This has some downsides I'm sure, but it might not be too bad considering all of the effort is being put into next anyway.

oliviertassinari · 2017-04-13T21:53:42Z

@rsolomon Option 3 sounds fine to me. The more version of React we support, the better. We can always change the strategy if that introduce issues.

Use React 15.5 and proptypes

7e59266

muibot added the PR: Needs Review label Apr 11, 2017

Fix incorrect ES5 import

ab8d278

muibot added PR: Needs Revision and removed PR: Needs Review labels Apr 11, 2017

Use test utils from react-dom

2c8628d

muibot added the PR: Needs Review label Apr 11, 2017

oliviertassinari removed the PR: Needs Review label Apr 11, 2017

Comment out throwing errors from console.error for now

48b7d83

muibot added the PR: Needs Review label Apr 11, 2017

muibot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: Needs Review labels Apr 11, 2017

Merge branch 'master' into proptypes

dc16952

muibot added PR: Needs Review and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 11, 2017

mbrookes removed the PR: Needs Revision label Apr 11, 2017

oliviertassinari requested changes Apr 12, 2017

View reviewed changes

gaearon suggested changes Apr 12, 2017

View reviewed changes

prop-types to dependencies; fix white-space issues

553d1fb

gaearon reviewed Apr 12, 2017

View reviewed changes

Update version of prop-types to avoid critical issues

6ebcc1a

DanielRamosAcosta mentioned this pull request Apr 12, 2017

React.PropTypes validation Failed. #4901

Closed

oliviertassinari requested changes Apr 12, 2017

View reviewed changes

Ross Solomon added 2 commits April 13, 2017 10:13

Bump back versions where not required; fix remaining warnings

5eee21c

Revert versions to correct ones

dca10a0

muibot added PR: Needs Revision and removed PR: Needs Review labels Apr 13, 2017

Bump enzyme to depend on newer test utils

55660e3

muibot added the PR: Needs Review label Apr 13, 2017

oliviertassinari approved these changes Apr 13, 2017

View reviewed changes

mbrookes merged commit 912649d into mui:master Apr 13, 2017

oliviertassinari added PR: Review Accepted and removed PR: Needs Review labels Apr 13, 2017

mbrookes mentioned this pull request Apr 17, 2017

[docs] PropTypes.oneOf properties don't render correctly #6612

Closed

zannager added the docs Improvements or additions to the documentation. label Mar 15, 2023

		@@ -1,4 +1,6 @@
		import React, {Component, PropTypes} from 'react-native';
		import React, {Component} from 'react-native';

Uh oh!

Conversation

rsolomon commented Apr 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rsolomon commented Apr 11, 2017

Uh oh!

mbrookes commented Apr 11, 2017

Uh oh!

oliviertassinari commented Apr 11, 2017

Uh oh!

rsolomon commented Apr 11, 2017

Uh oh!

mbrookes commented Apr 11, 2017

Uh oh!

oliviertassinari left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rsolomon commented Apr 12, 2017

Uh oh!

oliviertassinari left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rsolomon commented Apr 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliviertassinari commented Apr 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rsolomon commented Apr 11, 2017 •

edited

Loading

oliviertassinari Apr 12, 2017 •

edited

Loading

oliviertassinari left a comment •

edited

Loading

oliviertassinari Apr 13, 2017 •

edited

Loading

rsolomon commented Apr 13, 2017 •

edited

Loading

oliviertassinari commented Apr 13, 2017 •

edited

Loading