add support for mjGEOM_SDF - #31
Merged
Merged
Conversation
kevinzakka
self-requested a review
August 7, 2026 01:46
kevinzakka
approved these changes
Aug 7, 2026
kevinzakka
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution @nmarticorena!
Contributor
|
Could you just fix the lint formatting test? |
Contributor
Author
|
Thanks for the quick response!, changes applied |
kevinzakka
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kevinzakka, first thanks for all the effort on both
mjviserandmjlabthere are awesome tools to use.This really small pr aims to add the capability to
mjviserto usemjGEOM_SDFobjects.From the mujoco docs the SDF plugin for custom shapes in a mesh-free manner, by defining methods computing a signed distance field and its gradient at query points that is quite useful for non-convex geometries, due to the sdf plugin computes a visual mesh for rendering using marching cubes the only requirement for
mjviseris treatingmjGEOM_SDFas a mesh.Currently when trying to load the xml example scene bowl.xm gets the current output:
After this small change the behavior is as expected
