Skip to content

fix(metrics): don't count conflict errors as reconcile failures #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niconosenzo merged 1 commit into from
Sep 14, 2026
+5 −2
Merged

fix(metrics): don't count conflict errors as reconcile failures #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/monitoring/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package monitoring

import (
"github.com/prometheus/client_golang/prometheus"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"sigs.k8s.io/controller-runtime/pkg/metrics"
)

Expand Down Expand Up @@ -167,9 +168,11 @@ func Collectors() []prometheus.Collector {

// RecordReconcileError increments the per-object reconcile error counter.
// It is a no-op when err is nil, so callers can defer it unconditionally
// over a named error return value.
// over a named error return value. Conflict errors are excluded: they
// indicate a concurrent update and are expected during normal operation,
// not a reconcile failure.
func RecordReconcileError(err error, controller, name, namespace string) {
if err == nil {
if err == nil || apierrors.IsConflict(err) {
return
}
reconcileErrorsTotal.WithLabelValues(controller, name, namespace).Inc()
Expand Down