ci(images): promote canary-validated runtime defaults by digest - #661
Merged
Merged
Conversation
- Update the six runtime defaults and promotion evidence atomically through one persistent PR after a successful scheduled canary. - Keep failed promotions retryable and separate from compatibility reporting, rejecting stale revisions and duplicate image updates. - Run promotion PR e2e against committed defaults. Signed-off-by: Verónica López <veronica.lopez@supabase.io>
This comment has been minimized.
This comment has been minimized.
- Derive local e2e pulls from committed defaults, including the Postgres exporter, while preserving explicit image lists. - Include the checked-out legacy image list for older frameworks and cover clean-cache loading with empty and partial overrides. Signed-off-by: Verónica López <veronica.lopez@supabase.io>
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
niconosenzo
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR promotes runtime image defaults after the scheduled upstream compatibility canary passes.
The nightly workflow already verifies immutable images and runs e2e, but it does not publish those tested images as operator defaults. A successful scheduled run now creates or updates one promotion PR containing the three verified digests and the evidence identifying what was built and tested.
Compatibility reporting and promotion remain independent. A green canary can close the compatibility incident, while a failed PR update leaves the workflow red and the revision eligible for retry.
Main changes
Testing
Regression tests verify that promotion updates all six defaults and their evidence together, newer image sets update the existing PR, and repeated sets leave the commit unchanged. Simulated PR creation and update failures check that publication can be retried without creating another commit or marking the revision handled prematurely. Coverage also checks rejection of manual runs, stale revisions, changed digests, and operator main advancing during the canary.
Workflow tests exercise missing architectures and failed provenance verification, and verify that a green canary can close the compatibility incident independently of promotion failure. The e2e framework tests check that image loading follows committed defaults while preserving partial overrides. Image-pulling tests start with an empty simulated Docker cache and cover local Make use plus current and older frameworks with empty, partial, and complete overrides. These tests pass locally. The complete scheduled promotion and Kind e2e path remains to be exercised in GitHub Actions.
Closes #586