Conversation
- Pass each pooler's full pod DNS address through --hostname to avoid registering an unresolvable short name after discovery fails. - Keep the address aligned with the headless service and backup TLS SANs. - Cover namespace, pool, cell, replica, truncated-name, and rollout behavior. Signed-off-by: Verónica López <veronica.lopez@supabase.io>
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR makes multipooler advertise its full pod DNS address explicitly.
When startup hostname discovery fails, Multigres falls back to a short pod name that other pods cannot resolve. In #664, that left the pooler unreachable to Multiorch and the operator, keeping its data readiness gate false even though its containers were healthy.
The operator now passes
--hostname=<pod>.<headless-service>.<namespace>.svc.cluster.local, using the names it already assigns. The address matches the existing backup TLS certificate names and cluster-domain convention. The changed pod spec hash brings existing poolers through the normal coordinated rollout.Main changes
Testing
make verify pre-commitpassed, including formatting, vet, lint, and the complete unit suite. The new regression test was also confirmed to fail against the original pod builder.TestWebhookRejections/RemovePoolpassed in an isolated Kind cluster with the runtime image digests from #664. All four poolers advertised the expected DNS addresses and reachedReady=Truewith the data readiness gate true.The first Kind run exhausted the readiness deadline after slow image downloads. The unchanged test passed in 50 seconds after the images were cached. Image preparation is addressed in a separate PR.
Closes #665
Related: #664