Conversation
- Keep the existing sequential loader for tagged images. - Check each node with crictl inspecti and pull missing exact digests. - Stop setup on pull failure before workload readiness checks begin. - Skip redundant host pulls and cover cache reuse and failure reporting. Signed-off-by: Verónica López <veronica.lopez@supabase.io>
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR prepares digest-pinned runtime images on every Kind node before deploying the operator or starting test workloads.
The existing loader skipped digest references, leaving kubelet to download them while the workload readiness deadline was running. Cold image downloads could therefore fail an otherwise healthy test.
Main changes
crictl inspecti; pull missing images withcrictl pull --pull-timeout=10m, preserving the exact reference and node platform.Testing
E2E framework tests passed with the race detector, covering exact references on two simulated nodes, cached images, and failure propagation through the command boundary. All 10 image setup script tests passed, with no new E2E-tagged lint findings.
A live two-node Kind smoke test passed in 7.31 seconds, covering cold exact-digest pulls, tagged operator image imports, cache reuse without another pull, and immediate setup failure for a nonexistent digest.
Related: #664