Skip to content

Handle multibyte selections in note panel #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
multiplex55 wants to merge 3 commits into from
Closed

Handle multibyte selections in note panel #625

multiplex55 wants to merge 3 commits into from

Conversation

@multiplex55
Copy link
Owner

@multiplex55 multiplex55 commented Jan 1, 2026

Summary

  • convert note panel selection handling to store and operate on byte-based selections before slicing content
  • add helper conversions between character and byte offsets for text insertion utilities
  • add a regression test covering bolding multi-byte text to prevent slice panics when toggling editing

Testing

  • cargo test wrap_selection_handles_multibyte_content (fails: missing system library alsa required by alsa-sys build script)

Codex Task

@multiplex55 multiplex55 closed this Jan 1, 2026
@multiplex55 multiplex55 deleted the codex/refactor-note-panel-selection-handling branch January 1, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@multiplex55