Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Sheetly packages to v1.0.2 while cleaning up migration/snapshot legacy compatibility pieces and refreshing repository assets/docs (banner, release notes paths, breaking-changes tracking).
Changes:
- Bump package/tool versions to 1.0.2 and update NuGet packed icon path to
assets/icon.png. - Remove legacy migration snapshot fields + legacy attribute capture logic.
- Update documentation/assets (new banner SVG, breaking changes doc) and adjust release workflow to use
docs/RELEASE_NOTES.md.
Reviewed changes
Copilot reviewed 20 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Sheetly.Google/Sheetly.Google.csproj | Version bump + pack icon path moved under assets/. |
| src/Sheetly.DependencyInjection/Sheetly.DependencyInjection.csproj | Version bump + pack icon path moved under assets/. |
| src/Sheetly.Core/Sheetly.Core.csproj | Version bump + pack icon path moved under assets/. |
| src/Sheetly.CLI/Sheetly.CLI.csproj | Version bump + pack icon path moved under assets/. |
| src/Sheetly.Core/SheetsSet.cs | Minor cleanup (comment/BOM adjustments). |
| src/Sheetly.Core/SheetsContext.cs | Minor cleanup (comment removal). |
| src/Sheetly.Core/Migrations/MigrationAttribute.cs | Refactor to primary-constructor style. |
| src/Sheetly.Core/Migration/MigrationSnapshot.cs | Removes legacy/obsolete snapshot members from ColumnSchema. |
| src/Sheetly.Core/Migration/MigrationBuilder.cs | Removes legacy attribute capture into snapshots. |
| src/Sheetly.CLI/Program.cs | Formatting adjustment. |
| src/Sheetly.CLI/Commands/AddCommand.cs | Minor cleanup (comment/BOM adjustments). |
| src/Sheetly.CLI/Commands/RemoveCommand.cs | Minor cleanup (comment/BOM adjustments). |
| src/Sheetly.CLI/Commands/UpdateCommand.cs | Minor cleanup (comment removal). |
| src/Sheetly.CLI/tools/init.ps1 | Removed PMC init script. |
| src/Sheetly.CLI/tools/Add-SheetlyMigration.ps1 | Removed PMC helper command script. |
| samples/Sheetly.Sample/AppDbContext.cs | Adds sample context demonstrating configuration/model setup. |
| samples/Sheetly.Sample/Migrations/AppDbModelSnapshot.cs | Formatting/cleanup of generated snapshot sample. |
| samples/Sheetly.Sample/Migrations/20260222142948_InitialCreate.cs | Formatting/cleanup of generated migration sample. |
| dotnet-tools.json | Removed empty tool manifest. |
| docs/RELEASE_NOTES.md | Updates release notes content and heading. |
| docs/BREAKING_CHANGES.md | Adds breaking changes tracking doc. |
| assets/banner.svg | Adds new banner graphic used by README. |
| README.md | Switches to banner + badge row layout. |
| .github/workflows/publish.yml | Points GitHub release body to docs/RELEASE_NOTES.md. |
Comments suppressed due to low confidence (1)
docs/RELEASE_NOTES.md:15
- docs/RELEASE_NOTES.md is now labeled as v1.0.1 (and the new section is "What's Fixed in v1.0.1"), but this PR bumps package versions to 1.0.2. Please align the release notes version/sections with the actual release being produced (or clarify why 1.0.2 packages ship 1.0.1 notes).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
61
to
67
| // Validation rules (JSON format for complex validations) | ||
| public string? ValidationRules { get; set; } | ||
|
|
||
| // Additional metadata | ||
| public string? Comment { get; set; } | ||
| public string? Collation { get; set; } | ||
|
|
||
| // Legacy support | ||
| [Obsolete("Use specific constraint properties instead")] | ||
| public string? Attributes { get; set; } | ||
|
|
||
| // Deprecated property name - use ForeignKeyTable | ||
| [Obsolete("Use ForeignKeyTable instead")] | ||
| public string? RelatedTable | ||
| { | ||
| get => ForeignKeyTable; | ||
| set => ForeignKeyTable = value; | ||
| } | ||
| } |
There was a problem hiding this comment.
Removing public properties from ColumnSchema (e.g., the previously-obsolete legacy fields) is a breaking change for any consumers that compiled against older versions or deserialize older snapshots. Either keep the legacy members (marked [Obsolete]) for backward compatibility, or treat this as a breaking change (document it and bump the package version accordingly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.