fix(security): add safeJoin() to block path traversal in fs ops#19
Closed
prix-cloud[bot] wants to merge 1 commit intomainfrom
Closed
fix(security): add safeJoin() to block path traversal in fs ops#19prix-cloud[bot] wants to merge 1 commit intomainfrom
prix-cloud[bot] wants to merge 1 commit intomainfrom
Conversation
Owner
|
Duplicate of #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Introduced
src/lib/paths.tswith asafeJoin(base, name)helper that:^[a-zA-Z0-9][a-zA-Z0-9._-]{0,63}$(no slashes, no.., no leading dots).base(defense-in-depth against any future bypass).Routed every user-named filesystem operation through
safeJoin:src/commands/plugins.tsplugins remove—fs.rmSyncon plugin rootsrc/lib/subagents.tsinstallSubagentCentrally,removeSubagent,installSubagentToAgent,removeSubagentFromAgent—fs.rmSync/fs.cpSync/fs.writeFileSync/fs.unlinkSyncsrc/lib/routines.tsreadJob,writeJob,deleteJob,getJobPath— YAML read/write/delete under~/.agents/routines/src/commands/routines.tsroutines edit— templatefs.writeFileSyncon new job filesrc/lib/permissions.tssavePermissionSet,removePermissionSet—fs.writeFileSync/fs.unlinkSyncunder~/.agents/permissions/groups/Why
path.join(baseDir, userInput)without validation allows../traversal. For example:…would call
fs.rmSync(~/Documents, { recursive: true }), wiping an arbitrary directory. Same class of bug existed in subagent, routine, and permission commands.How to test
Closes RUSH-555.