feat: expose localUfrag on IceUdpMuxRequest#420
Merged
murat-dogan merged 1 commit intomurat-dogan:masterfrom Apr 26, 2026
Merged
feat: expose localUfrag on IceUdpMuxRequest#420murat-dogan merged 1 commit intomurat-dogan:masterfrom
murat-dogan merged 1 commit intomurat-dogan:masterfrom
Conversation
Passes through `rtc::IceUdpMuxRequest::localUfrag` from libdatachannel to the JS `onUnhandledStunRequest` callback. Needed by the libp2p WebRTC-Direct v2 transport design (libp2p/specs#715). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
Owner
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes through
rtc::IceUdpMuxRequest::localUfragfrom libdatachannel to the JSonUnhandledStunRequestcallback. It was already parsed by libjuice and populated in the C++ struct — the N-API wrapper was just not forwarding it.Needed by the libp2p WebRTC-Direct v2 transport design (libp2p/specs#715), which encodes per-session state in the first half of the incoming STUN USERNAME — the half that maps to
localUfrag.v2 is driven by Chrome's plan to disallow SDP ufrag/pwd munging — the browser-side trick v1 depends on (https://issues.webrtc.org/issues/411871813). This passthrough unblocks server implementations of v2 so libp2p can stop relying on that behaviour.