Skip to content

32612: Do not make the main window transparent on startup anymore #32940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krasko78 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −9
Open

32612: Do not make the main window transparent on startup anymore #32940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/appshell/qml/MuseScore/AppShell/WindowContent.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ DockWindow {
onPageLoaded: {
console.log("WindowContent::onPageLoaded")
interactiveProvider.onPageOpened()
window.opacity = 1.0
}

InteractiveProvider {
Expand Down
10 changes: 2 additions & 8 deletions src/framework/ui/internal/guiapplication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,9 @@ bool GuiApplication::loadMainWindow(const muse::modularity::ContextPtr& ctxId)
return false;
}

// The main window must be shown at this point so KDDockWidgets can read its size correctly
// and scale all sizes properly. https://github.com/musescore/MuseScore/issues/21148
// but before that, let's make the window transparent,
// otherwise the empty window frame will be visible
// https://github.com/musescore/MuseScore/issues/29630
// Transparency will be removed after the page loads.

//! The main window must be shown at this point so KDDockWidgets can read its size correctly
//! and scale all sizes properly. https://github.com/musescore/MuseScore/issues/21148
QQuickWindow* window = dynamic_cast<QQuickWindow*>(obj);
window->setOpacity(0.01);
window->setVisible(true);

m_windows[ctxId->id] = window;
Expand Down
Loading