On save to cloud issues don't send users to musescore.org for help#33028
Open
Jojo-Schmitz wants to merge 2 commits intomusescore:masterfrom
Open
On save to cloud issues don't send users to musescore.org for help#33028Jojo-Schmitz wants to merge 2 commits intomusescore:masterfrom
Jojo-Schmitz wants to merge 2 commits intomusescore:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughReplaced MuseScore.org references with MuseScore.com in cloud error/help messaging (including the appended help line and fallback text in OpenSaveProjectScenario::showCloudSaveError and related cloudStatusCodeErrorMessage usage). Changed the “Get help” button to open configuration()->dotComBugReportUrl(). Added a new dotComBugReportUrl() accessor to IProjectConfiguration/ProjectConfiguration, and implemented/updated it in projectconfiguration.cpp, mocks, and stubs. 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/project/internal/opensaveprojectscenario.cpp`:
- Line 477: The UI text now references MuseScore.com but the help action still
calls configuration()->supportForumUrl() (used by the help button at the
open/save dialog), causing a mismatch; fix by either (A) updating
configuration()->supportForumUrl() so it returns the MuseScore.com help URL for
this flow, or (B) reverting the text changes that call out MuseScore.com (the
muse::trc("project/cloud", ...) strings that build the message) so they match
the existing configuration()->supportForumUrl() behavior; locate the message
construction using muse::trc("project/cloud", ...) and the help button
invocation that opens configuration()->supportForumUrl() and make the chosen
consistent change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d9867661-27b8-4234-8144-b49e06524d9b
📒 Files selected for processing (1)
src/project/internal/opensaveprojectscenario.cpp
Jojo-Schmitz
force-pushed
the
org_vs_com
branch
2 times, most recently
from
284070c to
912ed11
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/project/internal/opensaveprojectscenario.cpp`:
- Line 617: Replace the hardcoded QUrl in opensaveprojectscenario.cpp (the
platformInteractive()->openUrl(QUrl("https://musescore.com/groups/bug-reports"))
call) with a configuration-driven URL: add a new accessor cloudSupportUrl() to
the IProjectConfiguration interface and implement it in ProjectConfiguration to
return the cloud support QUrl, then call configuration()->cloudSupportUrl() (or
configuration()->cloudSupportUrl().toString() as needed) and pass that to
platformInteractive()->openUrl; this keeps the same destination but centralizes
and localizes the URL alongside the existing supportForumUrl().
- Around line 616-617: Remove the dead commented-out call to
configuration()->supportForumUrl() in the OpenSaveProjectScenario code path:
delete the line
"//platformInteractive()->openUrl(configuration()->supportForumUrl());" and
retain the active
platformInteractive()->openUrl(QUrl("https://musescore.com/groups/bug-reports"));
call so only the MuseScore.com URL is used; you can locate this in the
OpenSaveProjectScenario implementation where platformInteractive()->openUrl(...)
is invoked.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: ae7bd5ad-e446-44c4-8e0f-9b0b3b2d9b6d
📒 Files selected for processing (1)
src/project/internal/opensaveprojectscenario.cpp
Jojo-Schmitz
force-pushed
the
org_vs_com
branch
from
912ed11 to
077bfc4
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/project/iprojectconfiguration.h`:
- Line 140: Add the missing override for the new pure virtual method
dotComBugReportUrl() declared on IProjectConfiguration to the
ProjectConfigurationStub so the class is no longer abstract: declare QUrl
dotComBugReportUrl() const override; in ProjectConfigurationStub's header and
implement it in the stub's .cpp to return a stub value (e.g., QUrl()) inside the
ProjectConfigurationStub class implementation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6082038b-0b5f-4d6e-90f8-ec1bc78a9009
📒 Files selected for processing (5)
src/project/internal/opensaveprojectscenario.cppsrc/project/internal/projectconfiguration.cppsrc/project/internal/projectconfiguration.hsrc/project/iprojectconfiguration.hsrc/project/tests/mocks/projectconfigurationmock.h
Jojo-Schmitz
force-pushed
the
org_vs_com
branch
from
077bfc4 to
4bdee92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading to musescore.com fails, don't send users to to musescore.org for help, as there nobdy can help with those issues