Skip to content

Allow empty table views#33036

Open
saintmatthieu wants to merge 3 commits intomusescore:masterfrom
saintmatthieu:allow-empty-table-views
Open

Allow empty table views#33036
saintmatthieu wants to merge 3 commits intomusescore:masterfrom
saintmatthieu:allow-empty-table-views

Conversation

@saintmatthieu
Copy link
Copy Markdown
Contributor

Needed for Audacity PR audacity/audacity#10649

  • Allow empty table views: Audacity's plugin manager has filters that may yield no match. In that case, the displayed table should be empty.
  • Bubble up horizontal-header click: so that table views can react to those clicks, here to order the table rows after the clicked column, like is standard behavior.
  • expose displayTruncatedTextOnHover property of StyledTableView: in lieu of tooltips
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 03963c5c-41d4-47c9-87e4-4621e36f526c

📥 Commits

Reviewing files that changed from the base of the PR and between a0d3d2a and ac611ea.

📒 Files selected for processing (3)
  • src/framework/uicomponents/qml/Muse/UiComponents/StyledTableView.qml
  • src/framework/uicomponents/qml/Muse/UiComponents/abstracttableviewmodel.cpp
  • src/framework/uicomponents/qml/Muse/UiComponents/internal/StyledTableViewCell.qml
💤 Files with no reviewable changes (1)
  • src/framework/uicomponents/qml/Muse/UiComponents/abstracttableviewmodel.cpp

📝 Walkthrough

Walkthrough

This pull request introduces truncated-text-on-hover display capability to table views by adding a new displayTruncatedTextOnHover property that cascades from the main StyledTableView component through to individual table cells. Additionally, a new horizontalHeaderClicked signal is introduced to emit column index events when horizontal headers are clicked. The changes also modify the table model's setTable method to process empty table updates instead of ignoring them through early returns.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title "Allow empty table views" directly addresses one of the three main changes (empty table support) but incompletely represents the full scope of changes including horizontal header click bubbling and property exposure.
Description check ✅ Passed The description includes all three main changes, references related upstream work, includes completed checklist items, and provides clear motivation for the modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants