Skip to content

Add Sixteen Hole Chromatic#8

Closed
FTWynn wants to merge 1 commit intomusescore:masterfrom
FTWynn:master
Closed

Add Sixteen Hole Chromatic#8
FTWynn wants to merge 1 commit intomusescore:masterfrom
FTWynn:master

Conversation

@FTWynn
Copy link
Copy Markdown

@FTWynn FTWynn commented Aug 24, 2020

Based off the Standard Chromatic set

Based off the Standard Chromatic set
@FTWynn
Copy link
Copy Markdown
Author

FTWynn commented Aug 25, 2020

Actually... This doesn't seem to work right just yet. I'll keep toying with it and resubmit.

@FTWynn FTWynn closed this Aug 25, 2020
@Ismael-VC
Copy link
Copy Markdown

@FTWynn I have created new PR #12 Could you check it out?

@Ismael-VC
Copy link
Copy Markdown

I think it didn't work as you have it, because you have to start on C3 not C4, so either way you select "16 holes..." plus "Low C" key or you have to put something like this:

        var C3 = 48;
        var C4 = 60;
        var chromatic16Tuning = 13;

        if (harpkey == C4 && harp.tuning == chromatic16Tuning) {
            harpkey = C3;
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants