Skip to content

add a dataclass for stream mirrors#155

Open
benklop wants to merge 3 commits intomusic-assistant:mainfrom
benklop:add-stream-mirror-class
Open

add a dataclass for stream mirrors#155
benklop wants to merge 3 commits intomusic-assistant:mainfrom
benklop:add-stream-mirror-class

Conversation

@benklop
Copy link

@benklop benklop commented Jan 18, 2026

I want to use this in the digitallyincorporated provider to pass multiple URLs to the player, so it can fall back to a backup URL if needed

benklop added a commit to benklop/music-assistant-server that referenced this pull request Jan 18, 2026
@marcelveldt
Copy link
Member

Why don't we use MultiPartPath for this ?
Only thing we need to do is make sure the backend skips to the next path in the list if one fails

@benklop
Copy link
Author

benklop commented Jan 22, 2026 via email

@benklop
Copy link
Author

benklop commented Jan 22, 2026

Initially that's what I did, but I wasn't sure that behavior would really be correct for other users of MultiPartPath. I'm happy to do whatever those with more knowledge of the codebase think is the right direction though.

On Thu, Jan 22, 2026, 2:02 PM Marcel van der Veldt @.> wrote: marcelveldt left a comment (music-assistant/models#155) <#155 (comment)> Why don't we use MultiPartPath for this ? Only thing we need to do is make sure the backend skips to the next path in the list if one fails — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU2OYHPUWTIGWNAQKPNK2T4IENFTAVCNFSM6AAAAACSC7AWLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOBWGE3DOMRQG4 . You are receiving this because you authored the thread.Message ID: @.>

Why don't we use MultiPartPath for this ? Only thing we need to do is make sure the backend skips to the next path in the list if one fails

If we use MultiPartPath, consider the behavior if the stream being listened to is a livestream event, and the stream ends (as it is intended to). Do we want to, when the stream ends successfully, continue on to the next stream in the list (which is the same broadcast and presumably also has already ended)? I don't think that's probably the right behavior as they're supposed to be mirrors of each other, rather than items to be played sequentially. Perhaps an additional flag on MultiPartPath would be sufficient, indicating if they are mirrors or sequential.

@marcelveldt
Copy link
Member

An additional flag sounds good.

@marcelveldt
Copy link
Member

or we just allow path to be a list of strings (order determines priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants