docs: follow libmuslim 2026.08.19, five prescribed prayers and per-method high-latitude rule - #32
Merged
Merged
Conversation
…thod high-latitude rule libmuslim#63 removed sunrise and dhuha from struct PrayerTimes, and libmuslim#62 made the high-latitude rule a property of the calculation method. Release 2026.08.19 carries both, so every download pin moves from 2026.08.18 and prayertimes.h is documented at v0.2.0. Three claims were verified by running the documented code rather than edited by inspection, and two of them were wrong. The C and Rust quick-starts printed Isha 19:08 for Jakarta on 2026-07-12 under Kemenag. Both the C header and the Rust crate return 19:09. That page was already stale before this change. The Dart quick-start showed PrayerTimesUnavailable at Tromso in midsummer, listing fajr, sunrise, maghrib and isha. Under the default MWL parameters that call no longer throws at all, because MWL now carries a reference latitude of 45 for the polar case. The example now names Kemenag explicitly, which publishes no such rule, and the prayer list is the measured one. The app docs lose sunrise and dhuha as configurable prayers, matching muslimtify#74, and record that an existing config block for either keeps loading but has no effect. npm run build succeeds.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows libmuslim 2026.08.19, which carries two breaking changes: #63 removed
sunriseanddhuhafromstruct PrayerTimes, and #62 made the high-latitude rule a property of the calculation method.Ten files, across the C, Rust and Dart API pages and the muslimtify app docs.
Three code samples were verified by running them, and two were wrong
This is the part worth reviewing closely, because inspection alone would have shipped both errors.
The C and Rust quick-starts printed the wrong Isha. Both showed
Isha 19:08for Jakarta on 2026-07-12 under Kemenag. Compiling the documented C program and running the documented Rust program verbatim both give19:09. That page was stale before this change, so it is fixed here rather than carried forward.The Dart unavailable-times example no longer throws. It showed
PrayerTimesUnavailableat Tromso in midsummer:Under the default MWL parameters that call now succeeds and returns a Fajr of
00:27, because MWL carries a reference latitude of 45 for the polar case. The example would have been a lie about an exception that never fires.It now names Kemenag explicitly, which publishes no polar rule, and the list is measured rather than assumed:
The same location and method on 21 December loses only Maghrib, which the page also now states correctly. It previously claimed midwinter lost sunrise, dhuha and Maghrib.
Download pins
2026.08.18becomes2026.08.19, and the note explaining tag versus header version now readsprayertimes.hv0.2.0alongsidehijri.handtimezone.hatv0.1.0. I downloaded the published asset and confirmed it is byte-identical to libmuslimmainand carries the five-field struct, so the curl command and the page now agree.What the API pages say now
The struct, the
PrayerTimesfields in Rust and Dart, and the DartPrayerenum all drop the two members. Each page says what was removed and why, rather than silently showing a shorter list, since anyone readingt.sunriseneeds to know it will not compile.MethodParamsgainshigh_lat_methodandhigh_lat_refon the C page, andHighLatMethodgainsHIGHLAT_NEAREST_LATITUDE. The note there records that only 2 of the 22 methods carry a reference latitude and that the other 20 return non-finite times inside the polar circle deliberately, linking libmuslim#51.App docs
sunriseanddhuhaare gone from the accepted prayer names, the config example and the ihtiyat descriptions, matching muslimtify#74. The Dhuha section incalculation-methods.mdis removed.configuration.mdrecords the migration behaviour explicitly: a config file that still carries asunriseordhuhablock keeps loading, because the parser skips keys it does not recognise, but the block has no effect. That silence is worth documenting rather than leaving users to discover it.Verification